[DRAFT/DO NOT REVIEW] Kx/debugging discoverability poc #2529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * todo: doc | ||
| * @returns bool | ||
| */ | ||
| export function turnOnConsoleLog(): boolean { |
There was a problem hiding this comment.
probably no reason you need to return these booleans
| @@ -12,7 +13,59 @@ registerLogger.formatArgs = function (args) { | |||
| originalFormatArgsFunction.call(this, args); | |||
| }; | |||
|
|
|||
| const topLevelLogger = registerLogger('teamsJs'); | |||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | |||
| const createDebuggerFunction = (namespace: string): Debugger => { | |||
There was a problem hiding this comment.
This is cool and it will probably need a good dose of explanatory comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more information about how to contribute to this repo, visit this page.
Description
Main changes in the PR:
Validation
Validation performed:
Unit Tests added:
<Yes/No>
End-to-end tests added:
<Yes/No>
Additional Requirements
Change file added:
<Yes/No>
Related PRs:
Next/remaining steps:
Screenshots: